Changed redis backend to use aioredis instead of asyncio_redis. #8
Conversation
broadcaster/_backends/redis.py
Outdated
| await self._pub_conn.publish(channel, message) | ||
| await self._pub_conn.publish_json(channel, message) | ||
|
|
||
| async def _wait_for_channel(self) -> None: |
There was a problem hiding this comment.
I would try to find a way to avoid this. With async-redis it was possible, so I guess it should be possible to do it with aioredis, what do you think?
There was a problem hiding this comment.
Thanks, @woile. It would be good to find a solution because we have the same problem in redis-stream backend.
Maybe we need to change the way of subscription on the base class. what do you think?
There was a problem hiding this comment.
I have moved listener_task creation from connect to subscribe. now we don't need the _wait_for_channel function.
hramezani
force-pushed
the
change_redis_backend
branch
from
cac3b42 to
dbef3c3
Compare
hramezani
changed the title
|
Hello, Thank you for this great app. I see that the backend still relies on asyncio_redis, but it seems that this package is no longer maintained and aioredis is also became part of redis-py as well. I am wondering if there's any plan to replace asyncio_redis to redis-py by any chance. Thank you! |
|
Resolved in #111 |
4 participants
Based on @tomchristie comment.
I have added
await self._wait_for_channel(), to wait for the channel.