Conversation
|
still getting error logs during tests, deemed insubstantial: |
|
hmm, this may be relevant too, even if older: paritytech/substrate#14261 |
clangenb
left a comment
There was a problem hiding this comment.
looks good in general, some minor questions, and I might have spotted the missing serialize implementation error.
I made an issue of this. This is suspicious, in the worst case, it could mean that we forget to increment a provider count when we should, and as a result we might kill an account, which should not be killed yet. #333 |
Hmm, this probably means that we need to enable the Unfortunately, I just tried it and it seems to introduce an std-leackage.... |
I should have checked it more thoroughly, it does fix the runtime build. It is just the node, which also needs some fixes then. However, if the node requires this flag now in any case, it is better to enable encointer-primitive's |
noteworthy causes for change:
T::BlockNumberMovesBlocktoframe_systeminstead ofconstruct_runtimeand removesHeaderandBlockNumberparitytech/substrate#14437GenesisBuild<T,I>deprecated.BuildGenesisConfigadded. paritytech/substrate#14306Blocktoframe_systeminstead ofconstruct_runtimeand removesHeaderandBlockNumberparitytech/substrate#14437IndexforNonceparitytech/substrate#14290once merged, reset branch polkadot-v1.0.0