Moves Block to frame_system instead of construct_runtime and removes Header and BlockNumber

[gupnik]

Fixes #14126

Currently, one needs to define these params explicitly when using construct_runtime!

type Extrinsic = MockUncheckedExtrinsic<Runtime>;
type Block = MockBlock<Runtime>;

frame_support::construct_runtime!(
	pub struct Runtime
	where
		Block = Block,
		NodeBlock = Block,
		UncheckedExtrinsic = Extrinsic,
	{
		System: frame_system,
		Currency: pallet,
	}
);

This PR add these types as part of frame_system instead and allows the following:

frame_support::construct_runtime!(
	pub struct Runtime {
		System: frame_system,
		Currency: pallet_currency,
	}
);

Note that this change is backwards compatible. However, a warning is issued if the older syntax is still used.

Further, this PR also removes BlockNumber and Header from frame_system::Config. It instead uses Block to retrieve these using the trait HeaderProvider.

impl frame_system::Config for Runtime {
-    type Header = Header;
-    type BlockNumber = u32;
+    type Block = generic::Block<Header, UncheckedExtrinsic>;
}

Note that this is a breaking change.

Cumulus companion: paritytech/cumulus#2790
Polkadot companion: paritytech/polkadot#7431

[bkchr]

If this works, it looks much better IMO.

Did you checked on how much other things you need to change?

[gupnik]

If this works, it looks much better IMO.

Agreed.

Did you checked on how much other things you need to change?

It would still require a change at all places that get the BlockNumber using T::BlockNumber, though the change set will definitely be lesser than the previous one.

[gupnik]

bot fmt

[command-bot]

@gupnik https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3179287 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 15-baeb5df4-1743-4cf0-aef7-8e0a0f45d017 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@gupnik Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3179287 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3179287/artifacts/download.

[gupnik]

bot merge