Remove template subpackage and any references to it#173
Merged
Conversation
aaronayres35
commented
Nov 3, 2020
Comment on lines
-1
to
-4
| * Take a critical look at whether apptools.template should be in this project. | ||
| It appears to be adding a lot of dependencies the other packages do not need. | ||
| For now, its use is controlled through an extra. | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This file has not been edited since 2011, and it seems likely that all of these are now obsolete. Even though it is orthogonal, should I just delete this file with this PR (I can open github issues for any of the bullets if needed, but they appear no longer relevant)?
Contributor
There was a problem hiding this comment.
let's do that in a separate PR.
aaronayres35
changed the title
rahulporuri
approved these changes
Nov 4, 2020
Contributor
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM. I dont see any documentation for the template submodule so this PR looks complete.
This was referenced Nov 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #141
fixes #140
The fate of the
templatesubpackage has been decided, and it was decided that it should be removed entirely.This PR deletes the
templatesubpackage and removes any references to it from the code base.