Update changelog with entries for PRs removing entire subpackages#180
Closed
aaronayres35 wants to merge 1 commit into
Closed
Update changelog with entries for PRs removing entire subpackages#180aaronayres35 wants to merge 1 commit into
aaronayres35 wants to merge 1 commit into
Conversation
Contributor
Author
|
Ah, I just now am seeing the slack discussion. We may not want to go through with this PR if we are instead going with an |
rahulporuri
approved these changes
Nov 4, 2020
Contributor
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM. I wasn't sure if we were linking to issues or PRs but it looks like the changelog for 4.5.0 links to PRs so this is good.
Contributor
|
@aaronayres35 can you hold off on merging until we make a decision on #181 ? |
Contributor
Author
|
Closing as #181 was merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PRs #172, #173, and #175 the
appscripting,template, andpermissionssubpackages were removed. This PR simply updates the changelog to record these changes for the 5.0.0 release.