Remove permissions subpackage, its docs and examples, and references to it#175
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
==========================================
+ Coverage 40.10% 46.02% +5.92%
==========================================
Files 240 208 -32
Lines 8912 7767 -1145
Branches 1162 1061 -101
==========================================
+ Hits 3574 3575 +1
+ Misses 5192 4047 -1145
+ Partials 146 145 -1
Continue to review full report at Codecov.
|
rahulporuri
approved these changes
Nov 4, 2020
Contributor
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM.
I'm sure we won't forget when the time comes but just to be safe, can you update the changelog file with entries for this PR and the other two which remove entire submodules?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #174
This PR deletes the entire
apptools.permissionssubpackage along with its related docs and examples. Additionally, it removes any other references to it insideapptools.