Skip to content

Setup Appveyor#445

Merged
rahulporuri merged 6 commits into
masterfrom
ci/setup-appveyor
Jun 12, 2019
Merged

Setup Appveyor#445
rahulporuri merged 6 commits into
masterfrom
ci/setup-appveyor

Conversation

@rahulporuri
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri commented Jun 2, 2019

The appveyor related additions made in this PR are based on the appveyor setup in traitsui.

  • the edm version used in 1.9.1 while travis uses 1.11.0
  • tests are run on python 2.7, 3.5 and 3.6 with the toolkits null, pyqt on all runtimes and pyside, wx on python 2 specifically, like travis.

Edit: closes #377

Poruri Sai Rahul added 2 commits June 2, 2019 13:09
	new file:   appveyor-clean-cache.txt
	new file:   appveyor-run.cmd
	new file:   appveyor.yml
	new file:   install-edm-windows.cmd
	modified:   appveyor.yml
@rahulporuri
Copy link
Copy Markdown
Contributor Author

Note that both the 3.5 and 3.6 appveyor CI jobs finished running the tests successfully but they are marked as failures because of these tracebacks which appear when running the test suite

appveyor-run.cmd test %runtime% %toolkits%
Running tests in 'chaco-test-3.5-null'
copying file to tempdir: .coveragerc
[EXECUTING] edm run -e chaco-test-3.5-null -- coverage run -m unittest discover -v chaco
Could not covert font to FontEntry for file c:\windows\fonts\ebrima.ttf
Traceback (most recent call last):
  File "c:\users\appveyor\.edm\envs\chaco-test-3.5-null\lib\site-packages\kiva\fonttools\font_manager.py", line 1440, in <module>
    fontManager = pickle_load(_fmcache)
  File "c:\users\appveyor\.edm\envs\chaco-test-3.5-null\lib\site-packages\kiva\fonttools\font_manager.py", line 1050, in pickle_load
    fh = open(filename, 'rb')
FileNotFoundError: [Errno 2] No such file or directory: 'C:\\Users\\appveyor\\AppData\\Roaming\\Enthought\\kiva\\fontList.cache'

@rahulporuri
Copy link
Copy Markdown
Contributor Author

OTOH, on Python 2, we don't see the font-related tracebacks but we do see the following traceback after all of the testsuites are run, which I guess is being interpreted as a failed job

Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "c:\users\appveyor\.edm\envs\chaco-test-2.7-wx\lib\atexit.py", line 24, in _run_exitfuncs
    func(*targs, **kargs)
PyAssertionError: C++ assertion "GetEventHandler() == this" failed at ..\..\src\common\wincmn.cpp(478) in wxWindowBase::~wxWindowBase(): any pushed event handlers must have been removed
Error in sys.exitfunc:
Traceback (most recent call last):
  File "c:\users\appveyor\.edm\envs\chaco-test-2.7-wx\lib\atexit.py", line 24, in _run_exitfuncs
    func(*targs, **kargs)
wx._core.PyAssertionError: C++ assertion "GetEventHandler() == this" failed at ..\..\src\common\wincmn.cpp(478) in wxWindowBase::~wxWindowBase(): any pushed event handlers must have been removed

@rahulporuri rahulporuri changed the title [WIP] Setup Appveyor Setup Appveyor Jun 2, 2019
Comment thread appveyor.yml Outdated
@jvkersch
Copy link
Copy Markdown
Contributor

jvkersch commented Jun 3, 2019

@rahulporuri Thanks for picking this up, this is great!

Do you have any spare cycles to investigate those two tracebacks further?

@rahulporuri
Copy link
Copy Markdown
Contributor Author

Do you have any spare cycles to investigate those two tracebacks further?

I don't really know where the start.

@jvkersch
Copy link
Copy Markdown
Contributor

jvkersch commented Jun 3, 2019

I don't really know where the start.

Hah, neither do I -- I was hoping you did :-) I've never seen the FileNotFoundError, but the C++ cleanup issue comes up on other platforms as well. I'll do some digging (time permitting) and maybe we can compare notes later on and see if we get anywhere?

@corranwebster
Copy link
Copy Markdown
Contributor

The second traceback is a WxPython issue caused by not properly disconnecting event handlers. If I recall, @RobinD42 fixed this in TraitsUI with this PR enthought/traitsui#108 . A similar fix may be needed in Enable?

Both of these tracebacks are almost certainly Enable/Kiva problems not Chaco bugs.

Poruri Sai Rahul added 3 commits June 8, 2019 15:18
	modified:   appveyor.yml
	modified:   install-edm-windows.cmd
	modified:   install-edm-windows.cmd
@rahulporuri
Copy link
Copy Markdown
Contributor Author

@jvkersch I haven't been able to spend time investigating the tracebacks in the CI. Are you okay with merging this PR and opening issues to investigate the tracebacks?

@jvkersch
Copy link
Copy Markdown
Contributor

Are you okay with merging this PR and opening issues to investigate the tracebacks?

Sounds good! Merge away.

@rahulporuri
Copy link
Copy Markdown
Contributor Author

merging now that the webhook for appveyor has been added

@rahulporuri rahulporuri merged commit 60682a3 into master Jun 12, 2019
@rahulporuri rahulporuri deleted the ci/setup-appveyor branch June 12, 2019 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

runnings tests on Win - Appveyor

3 participants