Pop all evthandlers#108
Merged
Merged
Conversation
Contributor
|
Should a similar change be made in PyFace? |
Contributor
|
This has been sitting here for a while, probably because no-one feels fluent enough in the Wx internals. I'd suggest going ahead and merging this, @RobinD42 as long as you are comfortable with it and willing to deal with issues that might arise from the change. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wx 2.9 requires that all pushed wx.EvtHandlers be popped before a window is destroyed. This change is also compatible with 2.8 and may also solve part of the memory leak issue reported in issue #98.