REL: 4.8.0#472
Closed
jvkersch wants to merge 3 commits into
Closed
Conversation
Contributor
|
LGTM |
corranwebster
approved these changes
Jul 22, 2019
Member
|
I hope this wasn't still waiting on me :-(. I'll do some testing this afternoon, but the release needn't wait on that. |
Contributor
Author
|
@mdickinson I'm embarrassed to say that when I created the release PR I managed to not include your fixes. I need to revisit that and create a |
Member
|
@jvkersch Okay, will wait on that. Please ping me on the new PR when it happens. |
Merged
Contributor
Author
|
Replaced by #476 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up from #460 and adds three more sets of changes (#469, #470, #471)
@mdickinson Since you already reviewed the earlier release PR, do you want to have another look here?