REL: 4.8.0

[jvkersch]

This time this has all the necessary changes ;-)

I've double-checked that tests pass in a new (Python 3.7) environment. There are some deprecation warnings (ticketed in #475) that should be looked at but aren't urgent. While testing, I also ran into enthought/enable#360, which was tricky to get round (my home machine runs Arch Linux, which doesn't ship with swig-3 any longer).

@mdickinson This is the follow-up from #472

[mdickinson]

I've double-checked that tests pass in a new (Python 3.7) environment.

Thanks! I'll take some minutes to make that a triple-check.

[mdickinson]

A few warnings while creating the sdist:

warning: no files found matching 'chaco/tools/toolbars/images*.png'
warning: no files found matching 'chaco/tools/toolbars/images*.svg'
warning: no files found matching 'chaco/tools/toolbars/images*.txt'
warning: no previously-included files matching '*.pyc' found under directory 'examples'
warning: no files found matching 'dev_requirements.txt'

[mdickinson]

Looking good to me on Python 3.7.4 / macOS 10.14.6 / packages from PyPI, modulo the NumPy deprecation warnings that you already noted. Full transcript follows.

mirzakhani:~ mdickinson$ cd ~/Enthought/ETS/chaco/
mirzakhani:chaco mdickinson$ git describe && git status
4.7.0-176-g90836aec
HEAD detached at 90836aec
nothing to commit, working tree clean
mirzakhani:chaco mdickinson$ python setup.py sdist >/dev/null
warning: no files found matching 'chaco/tools/toolbars/images*.png'
warning: no files found matching 'chaco/tools/toolbars/images*.svg'
warning: no files found matching 'chaco/tools/toolbars/images*.txt'
warning: no previously-included files matching '*.pyc' found under directory 'examples'
warning: no files found matching 'dev_requirements.txt'
mirzakhani:chaco mdickinson$ cp -i dist/chaco-4.8.0.tar.gz ~/Desktop/
mirzakhani:chaco mdickinson$ cd ~/Desktop/
mirzakhani:Desktop mdickinson$ python -m venv chacotest
mirzakhani:Desktop mdickinson$ source chacotest/bin/activate
(chacotest) mirzakhani:Desktop mdickinson$ python --version
Python 3.7.4
(chacotest) mirzakhani:Desktop mdickinson$ pip install -q --upgrade pip
(chacotest) mirzakhani:Desktop mdickinson$ pip install -q Cython numpy mock
(chacotest) mirzakhani:Desktop mdickinson$ pip install -q chaco-4.8.0.tar.gz
(chacotest) mirzakhani:Desktop mdickinson$ python -m unittest discover -q chaco
/Users/mdickinson/Desktop/chacotest/lib/python3.7/site-packages/chaco/tests/test_contour.py:28: DeprecationWarning: PyArray_FromDims: use PyArray_SimpleNew.
  levels = c.trace(0.0)
/Users/mdickinson/Desktop/chacotest/lib/python3.7/site-packages/chaco/tests/test_contour.py:28: DeprecationWarning: PyArray_FromDimsAndDataAndDescr: use PyArray_NewFromDescr.
  levels = c.trace(0.0)
/Users/mdickinson/Desktop/chacotest/lib/python3.7/site-packages/chaco/tests/test_contour.py:41: DeprecationWarning: PyArray_FromDims: use PyArray_SimpleNew.
  levels = c.trace(1.0)
/Users/mdickinson/Desktop/chacotest/lib/python3.7/site-packages/chaco/tests/test_contour.py:41: DeprecationWarning: PyArray_FromDimsAndDataAndDescr: use PyArray_NewFromDescr.
  levels = c.trace(1.0)
/Users/mdickinson/Desktop/chacotest/lib/python3.7/site-packages/chaco/tests/test_contour.py:55: DeprecationWarning: PyArray_FromDims: use PyArray_SimpleNew.
  levels = c.trace(2.0)
/Users/mdickinson/Desktop/chacotest/lib/python3.7/site-packages/chaco/tests/test_contour.py:55: DeprecationWarning: PyArray_FromDimsAndDataAndDescr: use PyArray_NewFromDescr.
  levels = c.trace(2.0)
/Users/mdickinson/Desktop/chacotest/lib/python3.7/site-packages/chaco/tests/test_contour.py:63: DeprecationWarning: PyArray_FromDims: use PyArray_SimpleNew.
  levels = c.trace(2.5)
/Users/mdickinson/Desktop/chacotest/lib/python3.7/site-packages/chaco/tests/test_contour.py:63: DeprecationWarning: PyArray_FromDimsAndDataAndDescr: use PyArray_NewFromDescr.
  levels = c.trace(2.5)
----------------------------------------------------------------------
Ran 524 tests in 2.729s

OK (skipped=16)

[mdickinson]

Same tests with a Python 2.7.16 virtualenv. (Still looks good.)

mirzakhani:Desktop mdickinson$ virtualenv-2.7 chacotest2
New python executable in /Users/mdickinson/Desktop/chacotest2/bin/python
Installing setuptools, pip, wheel...
done.
mirzakhani:Desktop mdickinson$ source chacotest2/bin/activate
(chacotest2) mirzakhani:Desktop mdickinson$ python --version
Python 2.7.16
(chacotest2) mirzakhani:Desktop mdickinson$ pip install -q --upgrade pip
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
(chacotest2) mirzakhani:Desktop mdickinson$ pip install -q Cython numpy
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
(chacotest2) mirzakhani:Desktop mdickinson$ pip install -q chaco-4.8.0.tar.gz 
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
(chacotest2) mirzakhani:Desktop mdickinson$ pip install -q mock
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
(chacotest2) mirzakhani:Desktop mdickinson$ python -m unittest discover -q chaco
Usage: python -m unittest discover [options]

python -m unittest discover: error: no such option: -q
(chacotest2) mirzakhani:Desktop mdickinson$ python -m unittest discover chaco
..................s..........................................................................................ss.....................................................................................................s....................................sss............................................................................................s........................................s........s.s.........s.................................................................................................................ssss
----------------------------------------------------------------------
Ran 524 tests in 2.777s

OK (skipped=16)

[mdickinson]

LGTM!

[mdickinson]

One fairly harmless warning from twine check:

(chacotest2) mirzakhani:chaco mdickinson$ twine check dist/chaco-4.8.0.tar.gz 
Checking distribution dist/chaco-4.8.0.tar.gz: warning: `long_description_content_type` missing.  defaulting to `text/x-rst`.
Passed

[jvkersch]

Thanks @mdickinson ! I've uploaded the tarball to PyPI and I've tagged the release commit.

[mdickinson]

And as a final check, all the tests pass for me after installing from PyPI:

mirzakhani:Desktop mdickinson$ python -m venv chacotest && source chacotest/bin/activate
(chacotest) mirzakhani:Desktop mdickinson$ pip install -q --upgrade pip Cython numpy mock
(chacotest) mirzakhani:Desktop mdickinson$ pip install -q chaco
(chacotest) mirzakhani:Desktop mdickinson$ python -m unittest discover -q chaco
/Users/mdickinson/Desktop/chacotest/lib/python3.7/site-packages/chaco/tests/test_contour.py:28: DeprecationWarning: PyArray_FromDims: use PyArray_SimpleNew.
  levels = c.trace(0.0)
/Users/mdickinson/Desktop/chacotest/lib/python3.7/site-packages/chaco/tests/test_contour.py:28: DeprecationWarning: PyArray_FromDimsAndDataAndDescr: use PyArray_NewFromDescr.
  levels = c.trace(0.0)
/Users/mdickinson/Desktop/chacotest/lib/python3.7/site-packages/chaco/tests/test_contour.py:41: DeprecationWarning: PyArray_FromDims: use PyArray_SimpleNew.
  levels = c.trace(1.0)
/Users/mdickinson/Desktop/chacotest/lib/python3.7/site-packages/chaco/tests/test_contour.py:41: DeprecationWarning: PyArray_FromDimsAndDataAndDescr: use PyArray_NewFromDescr.
  levels = c.trace(1.0)
/Users/mdickinson/Desktop/chacotest/lib/python3.7/site-packages/chaco/tests/test_contour.py:55: DeprecationWarning: PyArray_FromDims: use PyArray_SimpleNew.
  levels = c.trace(2.0)
/Users/mdickinson/Desktop/chacotest/lib/python3.7/site-packages/chaco/tests/test_contour.py:55: DeprecationWarning: PyArray_FromDimsAndDataAndDescr: use PyArray_NewFromDescr.
  levels = c.trace(2.0)
/Users/mdickinson/Desktop/chacotest/lib/python3.7/site-packages/chaco/tests/test_contour.py:63: DeprecationWarning: PyArray_FromDims: use PyArray_SimpleNew.
  levels = c.trace(2.5)
/Users/mdickinson/Desktop/chacotest/lib/python3.7/site-packages/chaco/tests/test_contour.py:63: DeprecationWarning: PyArray_FromDimsAndDataAndDescr: use PyArray_NewFromDescr.
  levels = c.trace(2.5)
----------------------------------------------------------------------
Ran 524 tests in 2.748s

OK (skipped=16)