Use api modules for ETS packages where possible#643
Conversation
aaronayres35
left a comment
There was a problem hiding this comment.
All the changes here LGTM
On this branch I am still seeing some imports that aren't from api modules though.
eg in chaco/api.py we import BaseTool and KeySpec from enable.base_tool not enable.api, or markers in chaco/scatter_markers.py, etc.
I had opened #628
Ahh. I forgot to open this issue. Looks like this module can/should be removed too - because code from here got moved to enable - and this module was kept around for backwards compatibility - https://github.com/enthought/chaco/blob/f7cdff7bac428852b343f5311fb397c08a19c789/chaco/scatter_markers.py. I'll open an issue |
added comment in #580 |
fixes #618 and #605
This PR updates the code (package and examples) to make use of the api modules where possible for ETS packages.