Skip to content

Use api modules for ETS packages where possible#643

Merged
rahulporuri merged 2 commits into
masterfrom
dev/use-api-modules-where-possible
Apr 12, 2021
Merged

Use api modules for ETS packages where possible#643
rahulporuri merged 2 commits into
masterfrom
dev/use-api-modules-where-possible

Conversation

@rahulporuri
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri commented Apr 12, 2021

fixes #618 and #605

This PR updates the code (package and examples) to make use of the api modules where possible for ETS packages.

Copy link
Copy Markdown
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes here LGTM

On this branch I am still seeing some imports that aren't from api modules though.

eg in chaco/api.py we import BaseTool and KeySpec from enable.base_tool not enable.api, or markers in chaco/scatter_markers.py, etc.

@rahulporuri
Copy link
Copy Markdown
Contributor Author

in chaco/api.py we import BaseTool and KeySpec from enable.base_tool not enable.api,

I had opened #628

or markers in chaco/scatter_markers.py

Ahh. I forgot to open this issue. Looks like this module can/should be removed too - because code from here got moved to enable - and this module was kept around for backwards compatibility - https://github.com/enthought/chaco/blob/f7cdff7bac428852b343f5311fb397c08a19c789/chaco/scatter_markers.py. I'll open an issue

@rahulporuri
Copy link
Copy Markdown
Contributor Author

I'll open an issue

added comment in #580

@rahulporuri rahulporuri merged commit 080aaf5 into master Apr 12, 2021
@rahulporuri rahulporuri deleted the dev/use-api-modules-where-possible branch April 12, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use api modules in examples and tutorials where possible

2 participants