Skip to content

Remove unnecessary uses of "use_draw_order" #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahulporuri merged 2 commits into from
Apr 15, 2021
Merged

Remove unnecessary uses of "use_draw_order" #661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0fd11d
CLN : Remove unnecessary uses of use_draw_order
Apr 13, 2021
771591d
Merge branch 'master' of github.com:enthought/chaco into cln/use_draw…
Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions chaco/barplot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,6 @@ class BarPlot(AbstractPlotRenderer):
#: Overall alpha value of the image. Ranges from 0.0 for transparent to 1.0
alpha = Range(0.0, 1.0, 1.0, requires_redraw=True)

# use_draw_order = False

# Convenience properties that correspond to either index_mapper or
# value_mapper, depending on the orientation of the plot.

Expand Down
2 changes: 0 additions & 2 deletions chaco/color_bar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@ class ColorBar(AbstractPlotRenderer):
direction = Enum("normal", "flipped")
#: Overrides the default background color trait in PlotComponent.
bgcolor = "transparent"
#: Draw layers in "draw order"
use_draw_order = True
#: Default width is 40 pixels (overrides enable.CoordinateBox)
width = 40

Expand Down
14 changes: 2 additions & 12 deletions examples/demo/zoomed_plot/grid_plot_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ def create_gridded_line_plot(
orientation="vertical",
line_color="gray",
line_style="dot",
use_draw_order=True,
)

horizontal_grid = PlotGrid(
Expand All @@ -71,18 +70,14 @@ def create_gridded_line_plot(
orientation="horizontal",
line_color="gray",
line_style="dot",
use_draw_order=True,
)

vertical_axis = PlotAxis(
orientation="left", mapper=plot.value_mapper, use_draw_order=True
)
vertical_axis = PlotAxis(orientation="left", mapper=plot.value_mapper)

horizontal_axis = PlotAxis(
orientation="bottom",
title="Time (s)",
mapper=plot.index_mapper,
use_draw_order=True,
)

plot.underlays.append(vertical_grid)
Expand Down Expand Up @@ -150,7 +145,6 @@ def create_gridded_scatter_plot(
orientation="vertical",
line_color="gray",
line_style="dot",
use_draw_order=True,
)

horizontal_grid = PlotGrid(
Expand All @@ -159,18 +153,14 @@ def create_gridded_scatter_plot(
orientation="horizontal",
line_color="gray",
line_style="dot",
use_draw_order=True,
)

vertical_axis = PlotAxis(
orientation="left", mapper=plot.value_mapper, use_draw_order=True
)
vertical_axis = PlotAxis(orientation="left", mapper=plot.value_mapper)

horizontal_axis = PlotAxis(
orientation="bottom",
title="Time (s)",
mapper=plot.index_mapper,
use_draw_order=True,
)

plot.underlays.append(vertical_grid)
Expand Down
7 changes: 1 addition & 6 deletions examples/demo/zoomed_plot/zoom_plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ def configure_plot(plot, xlabel="Time (s)"):
orientation="vertical",
line_color="gray",
line_style="dot",
use_draw_order=True,
)

horizontal_grid = PlotGrid(
Expand All @@ -126,18 +125,14 @@ def configure_plot(plot, xlabel="Time (s)"):
orientation="horizontal",
line_color="gray",
line_style="dot",
use_draw_order=True,
)

vertical_axis = PlotAxis(
orientation="left", mapper=plot.value_mapper, use_draw_order=True
)
vertical_axis = PlotAxis(orientation="left", mapper=plot.value_mapper)

horizontal_axis = PlotAxis(
orientation="bottom",
title=xlabel,
mapper=plot.index_mapper,
use_draw_order=True,
)

plot.underlays.append(vertical_grid)
Expand Down