Remove unnecessary uses of "use_draw_order"#661
Merged
Conversation
and redefinition of the trait on a PlotComponent subclass and a commented out piece of code modified: chaco/barplot.py modified: chaco/color_bar.py modified: examples/demo/zoomed_plot/grid_plot_factory.py modified: examples/demo/zoomed_plot/zoom_plot.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary uses of
use_draw_orderin the code - which is by defaultTrue- and redefinition of theuse_draw_ordertrait on aPlotComponentsubclass and a commented out piece of code.Note that I tested the
zoomed_plotand it still works as expected. You need to dopython -m zoomed_plot.zoom_plotif you want to run the example (which I think needs to be documented somewhere).Related to #659