Use stacked layout utils from enable#673
Closed
rahulporuri wants to merge 1 commit into
Closed
Conversation
the utils seem to have been moved to enable a long time back but we dont seem to be using them in chaco note that there in one case the usage is slightly non-trivial because the enable util wasnt handling all of the cases in chaco modified: chaco/plot_containers.py
rahulporuri
commented
Apr 16, 2021
| ) | ||
|
|
||
| return self._cached_preferred_size | ||
| return stacked_preferred_size(self, components=components) |
Contributor
Author
There was a problem hiding this comment.
Note that there is some duplication here.
stacked_preferred_size does not handle the case where resizable="" - and we might want to update the underlying enable util to handle this case - but until then, we will have to explicitly handle the if self.fixed_preferred_size is not None: case AND the if self.resizable == "": case - and implicitly handle the if self.fixed_preferred_size is not None: case again inside the enable util, which will not do anything. under the circumstances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the stacked plot containers in chaco to use utils from enable. The utils seem to have been moved to enable a long time back but we just werent using them in chaco.