Handle preferred size computation when container isnt resizable#778
Merged
Conversation
added 2 commits
April 16, 2021 06:48
rahulporuri
changed the title
aaronayres35
approved these changes
Apr 22, 2021
Contributor
aaronayres35
left a comment
aaronayres35
left a comment
There was a problem hiding this comment.
LGTM
I see the same code in chaco. Unclear to me why it had been commented out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref
enthought/chaco#673. enthought/chaco#673 got closed in favor of enthought/chaco#674It looks like these lines were commented out from the original commit when this code was added to enable in 75fb3ac
and subsequently, the commented out code was removed in the PR #466