Update "super" usage#703
Merged
Merged
Conversation
On Python 3, we dont need to pass any arguments to super
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Python 3, we dont need to pass any arguments to
superin the usual case where we are simply callingsuperwith the defining class. This PR removes such instances.Note that the changes were made using automated regex-based search and replace, similar to enthought/traits#1280. After the changes were made, we checked each of the changes to ensure that we not passing a different class when calling
superthan the defining class e.g. callingsuper(A, self)in classBwhereBinherits fromA. There were a few such instances discovered in the code - which will be addressed in a later PR.