Update super usage#1280
Merged
Merged
Conversation
Member
|
@rahulporuri: where did you find this one?
I was hoping that after we'd blackened the codebase, all cases of this sort of spacing were gone. (And then that does indeed help with search-and-replace-type refactorings.) |
Contributor
Author
docs |
added 2 commits
August 26, 2020 08:32
done using automated search-replace using regex
modified: docs/source/traits_user_manual/advanced.rst modified: traits/has_traits.py
rahulporuri
force-pushed
the
cln/super-usage
branch
from
23fc7f2 to
fca9e73
Compare
This was referenced Aug 26, 2020
This was referenced Apr 20, 2021
This was referenced Jun 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up the usage of
super- I noticed that the codebase was a mix ofsuper(ClassName, self)andsuper()calls, which I have updated to usesuper()in this PR.The update was done using regex-search and replace. The regex string that works for
super(ClassName, self)is(super)+\(+(\w+)(,)+\s(self)+\)+, learnt/debugged using https://regex101.com/.After making changed using the automated search/replace, the changes were manually checked using
git add -p *.Finally, I manually searched the codebase for uses of
superwhich the regex didn't match e.g.super( ClassName , self )orsuper(ClassName,self)- which were manually updated.Checklist
TestsUpdate API reference (docs/source/traits_api_reference)Update User manual (docs/source/traits_user_manual)Update type annotation hints intraits-stubs