Skip to content

Update "super" usage#789

Merged
rahulporuri merged 1 commit into
masterfrom
cln/update-super-usage
Apr 21, 2021
Merged

Update "super" usage#789
rahulporuri merged 1 commit into
masterfrom
cln/update-super-usage

Conversation

@rahulporuri
Copy link
Copy Markdown
Contributor

This PR updates super usage using automated regex-based search and replace. After the changes were made, we reviewed each of the changes to ensure that we were calling the right class before.

See enthought/traits#1280

This commit updates super usage using automated regex-based search and
replace. After the changes were made, we reviewed each of the changes to
ensure that we were calling the right class before.
Copy link
Copy Markdown
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread enable/container.py
Comment on lines 575 to 576
# crappy... calling our parent's handler seems like a common traits
# event handling problem
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking this same thing when reviewing recent chaco PRs...

Comment thread enable/scrolled.py
@rahulporuri rahulporuri merged commit 6850385 into master Apr 21, 2021
@rahulporuri rahulporuri deleted the cln/update-super-usage branch April 21, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants