Update super usage in the "qt" backend#944
Merged
Merged
Conversation
This commit updates super usage in a semi-automated fashion. We used regex-based search and replace to update the super usage. Note that there were two instances where a super was being called with the wrong arguments - which got fixed in this commit.
rahulporuri
commented
Jun 14, 2021
| application_running = Event() | ||
|
|
||
| def __init__(self): | ||
| super(HasStrictTraits, self).__init__() |
Contributor
Author
There was a problem hiding this comment.
the second of two instances of potentially buggy super usage
aaronayres35
approved these changes
Jun 14, 2021
Contributor
There was a problem hiding this comment.
LGTM
I went through and checked for any "potentially buggy" cases as we have called them previously. Only found 2 which I believe should be fine. lol I had started this review before seeing your comments and hadn't refreshed. Disregard my comments as you have already pointed them out
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
superusage in a semi-automated fashion. We used regex-based search and replace to update thesuperusage. Note that there were two instances where a super was being called with the wrong arguments - which got fixed in this PR.See similar PR enthought/traits#1280