Skip to content

Update "super" usage in misc traitsui code#1589

Merged
rahulporuri merged 1 commit into
masterfrom
cln/update-super-usage-everywhere-else
Apr 23, 2021
Merged

Update "super" usage in misc traitsui code#1589
rahulporuri merged 1 commit into
masterfrom
cln/update-super-usage-everywhere-else

Conversation

@rahulporuri
Copy link
Copy Markdown
Contributor

This PR, together with #1587 and #1588, update super usage in the traitsui codebase. This PR, like other PRs, updated super using automated regex-based search and replace. After the changes were made, each call was checked to ensure that super was being called with the correct arguments.

Ref enthought/traits#1280.

This commit, together with other earlier PRs, update super usage in the
traitsui codebase. This commit, like other commits, updated super using
automated regex-based search and replace. After the changes were made,
each call was checked to ensure that super was being called with the
correct arguments.
)

def __init__(self, **traits):
super(HasTraits, self).__init__(**traits)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should have been ThreadDemo and included in #1583 but i missed it earlier.

Copy link
Copy Markdown
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri rahulporuri merged commit 7f24627 into master Apr 23, 2021
@rahulporuri rahulporuri deleted the cln/update-super-usage-everywhere-else branch April 23, 2021 15:05
rahulporuri pushed a commit that referenced this pull request Apr 26, 2021
Together with #1583, #1587 , #1588 and #1589 , this PR fixes #1167
rahulporuri pushed a commit that referenced this pull request Apr 26, 2021
Together with #1583, #1587 , #1588 and #1589 , this PR fixes #1167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants