remove calls to Component._draw_component#737
Merged
Conversation
rahulporuri
approved these changes
May 18, 2021
Contributor
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM.
This isn't enough to close #736 as we also want to remove the "deprecated" comments in the _draw_component once we take a better look at those methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #736 (maybe this is enough to close the issue? We may want to remove all use of _draw_component, even uses that won't break)
These 2 calls actually were calling
Component._draw_componentliving inenablewhich currently is a no-op:https://github.com/enthought/enable/blob/21c299e1229d74e9db701487a613934e332a7225/enable/component.py#L344-L350
There are other uses of
_draw_componentacross chaco that can be removed, but they will not cause a break if_draw_componentis removed inenable(ref enthought/enable#814), because the method gets overwritten in chaco.