Remove old deprecated drawing methods#814
Merged
Merged
Conversation
rahulporuri
approved these changes
May 18, 2021
| with gc: | ||
| gc.set_antialias(False) | ||
|
|
||
| self._draw_container(gc, mode) |
Contributor
There was a problem hiding this comment.
looks like this can also be removed because there are newer methods _draw_container_* where * is the respective layer.
Note that Scrolled._draw makes use of this _draw_container but at the moment, _draw_container doesn't do anything
Contributor
There was a problem hiding this comment.
I haven't verified that _draw_container can actually be removed - that was just my hunch given the brief amount of time spent reviewing this PR. You'll want to check chaco as well and handle this in a separate PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #794
closes #781
This PR removes the
_draw_componentmethods onContainer/Componentas well as the_draw_overlays(note_draw_overlayis still around) and_draw_childrenmethods on container.