Replace bg_color with bgcolor#742
Conversation
aaronayres35
changed the title
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM with a couple of comments/recommendations
| Item( | ||
| "plot", | ||
| editor=ComponentEditor(size=size, bgcolor=bg_color), | ||
| editor=ComponentEditor(size=size, bgcolor=bgcolor), |
There was a problem hiding this comment.
FTR : ComponentEditor is the only place where I see someone set bgcolor on an enable AbstractWindow - and it sets bgcolor, not the deprecated bg_color.
| # Attributes to use for the plot view. | ||
| size = (650, 650) | ||
| title = "Scatter plot with selection" | ||
| bg_color = "lightgray" |
There was a problem hiding this comment.
why not pass this to the ComponentEditor - like what we do in the other examples
There was a problem hiding this comment.
I can add that here in this PR. I deleted it just because previously this bg_color variable was just unused entirely.
It makes sense to actually use it though
| # Attributes to use for the plot view. | ||
| size = (650, 650) | ||
| title = "Scatter plot with selection" | ||
| bg_color = "lightgray" |
There was a problem hiding this comment.
same comment as above - why not pass this to the ComponentEditor, like we do with the other examples
|
Here's the original commit where |
2 participants
ref: enthought/enable#816 (review)
This PR removes uses of the soon to be removed, deprecated
bg_colortrait from enable. For consistency it renames all uses ofbg_colorin the codebase withbgcolor(even just temp variables), in order to keep consistent. Note, all changes occur in example code