Skip to content

Remove AbstractWindow.bg_color trait#816

Merged
aaronayres35 merged 1 commit into
masterfrom
remove-bg_color
May 18, 2021
Merged

Remove AbstractWindow.bg_color trait#816
aaronayres35 merged 1 commit into
masterfrom
remove-bg_color

Conversation

@aaronayres35
Copy link
Copy Markdown
Contributor

closes #812

This PR simply removes the old deprecated trait. Note searching the codebase for bg_color is what motivated issue #815. Perhaps enable/trait_defs/ui/wx/enable_rgba_color_editor.py should just be deleted? given 815 I imagine it is completely broken

@rahulporuri rahulporuri self-requested a review May 13, 2021 04:24
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we can remove this outright without worrying about breaking any code. Can you also search chaco for uses of bg_color, just to be safe?

Also, I think we can remove the enable_rgba_color_editor.py module but let's do that in a separate PR

@aaronayres35
Copy link
Copy Markdown
Contributor Author

Also, I think we can remove the enable_rgba_color_editor.py module but let's do that in a separate PR

👍 I've opened #817

@aaronayres35
Copy link
Copy Markdown
Contributor Author

aaronayres35 commented May 18, 2021

LGTM. I think we can remove this outright without worrying about breaking any code. Can you also search chaco for uses of bg_color, just to be safe?

After searching chaco for bg_color there are a few uses, but the majority of which bg_color is used as a temp variable that is passed to bgcolor. eg bgcolor=bg_color.
There are 2 problem uses tho:
https://github.com/enthought/chaco/blob/54a1b929d3e3932bc79e17de5995658bd30e1b37/examples/demo/basic/contour_cmap_plot.py#L65

https://github.com/enthought/chaco/blob/54a1b929d3e3932bc79e17de5995658bd30e1b37/examples/demo/basic/contour_plot.py#L60
All uses occur in example code, not in library code.

I will open a PR to address these in chaco
EDIT: I've opened enthought/chaco#742

@aaronayres35 aaronayres35 merged commit 2c8b60f into master May 18, 2021
@aaronayres35 aaronayres35 deleted the remove-bg_color branch May 18, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated "AbstractWindow.bg_color" trait

2 participants