Fix CursorTool issue with LogMapper#803
Conversation
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM.
Looks like this change was already made to CursorTool2D which is used for plots which inherit from Base2DPlot but the changes weren't applied earlier to CursorTool1D which is used for plots which inherit from BaseXYPlot.
|
Ah, similara to #804, this PR currently just makes a switch from one assumption to another. ie with the changes here, now the CursorTool will not work with LinearMappers. I will update the PR |
| data_pt = (self.index.get_data()[ndx], self.value.get_data()[ndx]) | ||
| if return_distance: | ||
| scrn_pt = self.map_screen(data_pt) | ||
| scrn_pt = self.map_screen(data_pt)[0] |
There was a problem hiding this comment.
Note this change is also made in #802
Both the changes to BaseXYPlot1.map_screen done there and LinearMapper.map_screen here can cause the return type to be an an array of shape (N,2).
|
Unfortunately a lot of these changes are some what related. The changes to |
3 participants
fixes #289
This PR pulls the content specific to #289 out from PR #726