Add regression test / fix for DataLabelTool#804
Merged
Conversation
This was referenced Jun 28, 2021
Contributor
Author
|
#802 was merged, so I merged master with this branch and now CI passes as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a regression test and a fix for the specific error reported on #550.
550 is a bit broader in scope though and would also include #802 (and probably more) to be closed.
Note the changes here were pulled from #726 in an effort to make smaller more reviewable PRs. However, there is some interconnectedness between these PRs. This PR should not be merged first, as it will break things without the change in #802
As the issue mentions, currently the
DataLabelToolis forced to assume theBasaeXYPlotway or theBase2DPlotway."This difference forces objects that interact with
AbstractPlotRenderersto make an assumption about the behavior of themap_screenmethod. For example, theDataLabelToolassumes the map_screen return shape matches that ofBaseXYPlotfor a single point ((2,)) ... And therefore this tool throws an exception when used with aBase2DPlot"This PR makes
DataLabelToolfollow theBase2DPlotway (which we are pushing as the new standard), and #802 makesBaseXYPlotdo the same. On this branch,DataLabelToolwill not work with aBaseXYPlot.EDIT: I've added a failing test for use of
DataLabelToolwith aBaseXYPlot. This test will pass once #802 is merged