Skip to content

Backport fixes for 5.1.1 release#853

Merged
corranwebster merged 5 commits into
maint/5.1from
fix/backport-5.1.1
Jan 24, 2023
Merged

Backport fixes for 5.1.1 release#853
corranwebster merged 5 commits into
maint/5.1from
fix/backport-5.1.1

Conversation

@corranwebster
Copy link
Copy Markdown
Contributor

Does what it says.

aaronayres35 and others added 4 commits January 24, 2023 09:16
* grab correct package set for using qt on ubuntu latest

* same changes to other action
* dont raise if datalow > datahigh

* additional NaN checking in auto_ticks

* add some logging about the bad range coming from the mappper

* better warning message
This adds a parallel set of tests for Python 3.8 rather than trying to adapt the current set of tests.  Also updates edmtool to allow Python 3.8 and PySide6, and pyproject.toml to allow for known issue with setuptools.

Needed to make one change to code due to newer version of NumPy being picked up.

No requirement that they pass for PRs to be mergeable yet, but will likely add that once this PR is approved.
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
@corranwebster corranwebster marked this pull request as draft January 24, 2023 10:45
@corranwebster
Copy link
Copy Markdown
Contributor Author

Waiting on #856 before merging.

@corranwebster corranwebster marked this pull request as ready for review January 24, 2023 13:08
Copy link
Copy Markdown
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@corranwebster corranwebster merged commit 728945c into maint/5.1 Jan 24, 2023
@corranwebster corranwebster deleted the fix/backport-5.1.1 branch January 24, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants