Replace use of apptools sweetpickle#48
Conversation
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM. I tested this against an internal application and the application is now happy.
Looks like there's a test (test_persistence) which makes me slightly happy.
It'd also be useful if we could store a pickled DataContext in the codebase and run tests against it - to ensure that we're maintaing backwards compatibility in terms of storing/restoring the DataContext objects.
Just to make sure I'm on the same page, so you mean we create a data context and save it to some file (this is a one time thing). Then we store that file in like Also should this be done in this PR, or a follow up PR and we push this through as is? |
Yup. That's exactly what i mean.
We can push this through as is - but it'd be good to add that pickle/test sooner rather than later so we can move on and not have codetools in the back of our minds. |
Closes #45
This PR replaces the use of
apptoolssweetpicklewithapptools.persistenceandpicklefrom the standard library (as was done in enthought/apptools#199)I believe the relevant code is covered by tests (e.g.
codetools/codetools/contexts/tests/data_context_test_case.py
Lines 28 to 43 in aa0d470
As a sanity check it would be good to test with an application that depends on codetools
DataContext