Create a data_context.pickle and add a simple test for the data context stored in that pickle file#49
Merged
Conversation
…xt stored in that pickle file
rahulporuri
approved these changes
Mar 19, 2021
Contributor
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
Almost LGTM. CI might be unhappy because you're not including the .pickle file in the package. You'll need to update package data or the manifest file.
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #48 see comment: #48 (review)
This PR adds a function to create a pickled data context file in
tests/data/data_context.picklewhich is only intended to be run once (I ran it right now and the generated file is included in the PR). Maybe I should throw out the function itself, to avoid it being run and overriding the current pickle? I left it so it is clear what the stored data context should look like.It also adds a test that mirrors the existing
test_persistenceonly using the long stored file. I am not sure if we want to run more tests on the store file? It seems if this tests passes, the other would be redundant so for now I have only included the simple one to check we can appropriately load theDataContextand get the object we would expect.