Skip to content

Conversation

@moi15moi
Copy link
Contributor

I simply runned the command: ruff check --select UP008 --fix --unsafe-fixes
For more detail about UP008, see https://docs.astral.sh/ruff/rules/super-call-with-parameters/
ruff version used: 0.11.13

Note that this is marked as a "unsafe-fixes" only because it can remove comments (which hasn't been the case).

@codecov
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.75%. Comparing base (ed2862f) to head (e7495c9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
comtypes/server/automation.py 0.00% 2 Missing ⚠️
comtypes/persist.py 0.00% 1 Missing ⚠️
comtypes/server/localserver.py 0.00% 1 Missing ⚠️
comtypes/viewobject.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #847   +/-   ##
=======================================
  Coverage   82.75%   82.75%           
=======================================
  Files         122      122           
  Lines       11246    11246           
=======================================
  Hits         9307     9307           
  Misses       1939     1939           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

I simply runned the command: ruff check --select UP008 --fix --unsafe-fixes
For more detail about UP008, see https://docs.astral.sh/ruff/rules/super-call-with-parameters/
ruff version used: 0.11.13

Note that this is marked as a "unsafe-fixes" only because it can remove comments (which hasn't been the case).
junkmd added a commit to junkmd/pywinauto that referenced this pull request Jun 12, 2025
@junkmd junkmd added this to the 1.4.12 milestone Jun 12, 2025
junkmd added a commit to junkmd/pywinauto that referenced this pull request Jun 12, 2025
@moi15moi
Copy link
Contributor Author

I see that you often use pywinauto to test the PR. Don't you think we should add what you do with pywinauto in the CI?

@junkmd
Copy link
Collaborator

junkmd commented Jun 12, 2025

Several years ago, we discussed this at pywinauto/pywinauto#1232, and I'm still not keen on adding CI settings that use pywinauto to comtypes.

I believe that monitoring whether a project breaks due to dependency changes should be handled within that project itself.
For example, comtypes depends on ctypes, but core developers would likely not allow adding tests to CPython that install comtypes.
My thinking is equivalent to that.

Currently, I'm manually triggering pywinauto's CI largely due to personal interest.

If you know of a way for pywinauto to detect updates to comtypes or other dependencies and run CI using a bot or GitHub Actions, I'd appreciate it if you could join the discussion happening within the pywinauto project.

Copy link
Collaborator

@junkmd junkmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

I also checked the patch coverage on codecov, and I don't see any particular problems given the changes.

@junkmd junkmd merged commit e34a053 into enthought:main Jun 12, 2025
87 of 101 checks passed
moi15moi added a commit to moi15moi/comtypes that referenced this pull request Jun 13, 2025
With this, the CI won't fails when the patch coverage isn't "good". Ex: enthought#847
Doc: https://docs.codecov.com/docs/commit-status
@moi15moi moi15moi mentioned this pull request Jun 13, 2025
junkmd pushed a commit that referenced this pull request Jun 13, 2025
With this, the CI won't fails when the patch coverage isn't "good". Ex: #847
Doc: https://docs.codecov.com/docs/commit-status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants