-
-
Notifications
You must be signed in to change notification settings - Fork 104
Run ruff check UP008 #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run ruff check UP008 #847
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
=======================================
Coverage 82.75% 82.75%
=======================================
Files 122 122
Lines 11246 11246
=======================================
Hits 9307 9307
Misses 1939 1939 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I simply runned the command: ruff check --select UP008 --fix --unsafe-fixes For more detail about UP008, see https://docs.astral.sh/ruff/rules/super-call-with-parameters/ ruff version used: 0.11.13 Note that this is marked as a "unsafe-fixes" only because it can remove comments (which hasn't been the case).
|
I see that you often use pywinauto to test the PR. Don't you think we should add what you do with pywinauto in the CI? |
|
Several years ago, we discussed this at pywinauto/pywinauto#1232, and I'm still not keen on adding CI settings that use I believe that monitoring whether a project breaks due to dependency changes should be handled within that project itself. Currently, I'm manually triggering pywinauto's CI largely due to personal interest. If you know of a way for |
junkmd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
I also checked the patch coverage on codecov, and I don't see any particular problems given the changes.
With this, the CI won't fails when the patch coverage isn't "good". Ex: enthought#847 Doc: https://docs.codecov.com/docs/commit-status
With this, the CI won't fails when the patch coverage isn't "good". Ex: #847 Doc: https://docs.codecov.com/docs/commit-status
I simply runned the command: ruff check --select UP008 --fix --unsafe-fixes
For more detail about UP008, see https://docs.astral.sh/ruff/rules/super-call-with-parameters/
ruff version used: 0.11.13
Note that this is marked as a "unsafe-fixes" only because it can remove comments (which hasn't been the case).