Skip to content

Conversation

@moi15moi
Copy link
Contributor

@moi15moi moi15moi commented Jun 13, 2025

With this, the CI won't fails when the patch coverage isn't "good". Ex where it fails: #847
Doc: https://docs.codecov.com/docs/commit-status

PS: This PR is following #775

With this, the CI won't fails when the patch coverage isn't "good". Ex: enthought#847
Doc: https://docs.codecov.com/docs/commit-status
@codecov
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.75%. Comparing base (e34a053) to head (5c52f73).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #852   +/-   ##
=======================================
  Coverage   82.75%   82.75%           
=======================================
  Files         122      122           
  Lines       11246    11246           
=======================================
  Hits         9307     9307           
  Misses       1939     1939           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@junkmd junkmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For patch coverage, I believe it's fine to change it at informational: true.
As for project coverage, while it's worth considering other configurations to detect extreme drops, setting precise thresholds is challenging.
Since Codecov bot comments will continue even if we set it to informational: true, let's proceed with this approach for now.

@junkmd junkmd added this to the 1.4.12 milestone Jun 13, 2025
@junkmd junkmd merged commit a0c7833 into enthought:main Jun 13, 2025
148 of 150 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants