Skip to content

Audit __init__ methods #739

@corranwebster

Description

@corranwebster

As seen in #737 and #736 there are some classes which are doing things like setting traits in the init method (particularly when before the super() call) or not passing values through. There can be legitimate reasons for doing this (eg. to guarantee that certain traits hold valid values before their trait change notifiers fire), but in some cases these are interfering with the expected behaviour of the classes.

Additional classes that should be investigated include ViewportToolbar and ViewportZoomTool . There are likely to be others.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions