Clarify __init__s which allow component as a pos. arg.#738
Merged
Conversation
jwiggins
commented
Mar 22, 2021
Comment on lines
+62
to
+65
| def __init__(self, component=None, **kw): | ||
| if component is not None: | ||
| self.component = component | ||
| super(AbstractOverlay, self).__init__(*args, **kw) | ||
| kw["component"] = component | ||
| super(AbstractOverlay, self).__init__(**kw) |
Member
Author
There was a problem hiding this comment.
I removed *args because the base class of this class, Component, doesn't accept positional args, and HasTraits will raise a TypeError if it gets any positional arguments.
Member
Author
|
Thanks for the feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #736
Fixes #737
Fixes #739
@corranwebster I see that
ViewportToolbarandViewportZoomToolalso havecomponent=Nonein their__init__method signatures.