Python 3.11 support#1042
Merged
Merged
Conversation
Contributor
Author
|
To proceed with this we need either:
|
ankit-gautam23
suggested changes
Apr 19, 2023
ankit-gautam23
left a comment
ankit-gautam23
left a comment
There was a problem hiding this comment.
If it can work with exclude let it be excluded unless there is some points that could be defended.
| - os: 'macos-latest' | ||
| toolkit: ['null', 'pyside6'] | ||
| python-version: ['3.11'] | ||
| include: |
There was a problem hiding this comment.
Why are we including this for this version? Is it needed?
Member
There was a problem hiding this comment.
This ensures that Wx code is still tested by this workflow
Contributor
Author
There was a problem hiding this comment.
@ankit-gautam23 This is a test suite which runs periodically and alerts Enthought devs if the tests fail due to upstream changes so we can take action. We want some testing on WxPython, but it isn't easily installable for Python 3.11 yet.
Contributor
Author
|
Tests should pass once celiagg/celiagg#118 is merged |
jwiggins
approved these changes
May 2, 2023
Contributor
Author
|
Thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run pip-based tests on 3.11. We can't do Wx, PySide2 or PyQt5 easily since there are no wheels.