Skip to content

Python 3.11 support #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corranwebster merged 7 commits into from
May 2, 2023
Merged

Python 3.11 support #1042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a851e07
Try 3.11 tests on linux with null backend.
corranwebster Apr 19, 2023
6ff06c2
Do more tests using 3.11.
corranwebster Apr 19, 2023
4339edf
Let's see if having Python available makes old celiagg install.
corranwebster Apr 19, 2023
09f2130
Update install celiagg main in tests.
corranwebster Apr 19, 2023
27119a9
Merge branch 'main' into enh/python-3-11-support
corranwebster Apr 21, 2023
731cfad
Use celiagg maintenance branch until celiagg has a release.
corranwebster Apr 21, 2023
642d87e
No longer install celiagg from git.
corranwebster May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/bleeding-edge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,13 @@ jobs:
strategy:
matrix:
os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
toolkit: ['null', 'pyside6', 'wx']
python-version: ['3.10']
exclude:
# No Wx wheels available for ubuntu or macos
- os: 'ubuntu-latest'
toolkit: 'wx'
- os: 'macos-latest'
toolkit: ['null', 'pyside6']
python-version: ['3.11']
include:
Copy link
Copy Markdown

@ankit-gautam23 ankit-gautam23 Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we including this for this version? Is it needed?

Copy link
Copy Markdown
Member

@jwiggins jwiggins Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ensures that Wx code is still tested by this workflow

Copy link
Copy Markdown
Contributor Author

@corranwebster corranwebster Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankit-gautam23 This is a test suite which runs periodically and alerts Enthought devs if the tests fail due to upstream changes so we can take action. We want some testing on WxPython, but it isn't easily installable for Python 3.11 yet.

# No Wx wheels available for Python 3.11, so test on 3.10
- os: 'windows-latest'
toolkit: 'wx'
python-version: '3.10'
runs-on: ${{ matrix.os }}
steps:
- name: Check out
Expand Down
17 changes: 11 additions & 6 deletions .github/workflows/test-with-pip.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,17 @@ jobs:
matrix:
os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
toolkit: ['null', 'pyside2', 'pyside6', 'pyqt5', 'wx']
python-version: ['3.8', '3.10']
python-version: ['3.8', '3.10', '3.11']
exclude:
# No Wx wheels available for Python 3.11
- toolkit: 'wx'
python-version: '3.11'
# No PySide2 wheels available for Python 3.11
- toolkit: 'pyside2'
python-version: '3.11'
# No PyQt5 wheels available for Python 3.11
- toolkit: 'pyqt5'
python-version: '3.11'
# No Wx wheels available for ubuntu or macos
- os: 'ubuntu-latest'
toolkit: 'wx'
Expand Down Expand Up @@ -50,11 +59,7 @@ jobs:
run: |
python -m pip install --upgrade pip wheel
- name: Install local packages
run: pip install ".[cairo,layout,pdf,svg,test,${{ matrix.toolkit }}]"
- name: Install celiagg manually
# This is needed until new release of celiagg
# - numpy is needed for install in current released version
run: pip install celiagg
run: pip install ".[celiagg,cairo,layout,pdf,svg,test,${{ matrix.toolkit }}]"
- name: Sanity check package version
run: pip list
- name: Run kiva test suite (Linux)
Expand Down