Rename "qt4" to "qt"#1043
Merged
Merged
Conversation
This will likely fail tests right now.
jwiggins
approved these changes
Apr 20, 2023
Comment on lines
+20
to
+23
| try: | ||
| from traitsui.qt.editor import Editor | ||
| except ModuleNotFoundError: | ||
| from traitsui.qt4.editor import Editor |
Member
There was a problem hiding this comment.
Doesn't this PR's change force us to use a traitsui which doesn't have a qt4 subpackage?
Contributor
Author
There was a problem hiding this comment.
No, it's currently backward compatible because it was low effort to do that (only 3-4 places needed try/excepts to achieve it) and it simplifies releasing.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
*.qt4.*modules as*.qt.*and adapt imports to account for changes in Pyface 8.0 and TraitsUI 8.0 while keeping backwards compatibility.It also removes some lingering PyQt4 support code.
This has some overlap with #1028 but doesn't fix everything that that PR does, so we still need that, or need to merge it into this.
As best I can tell, this change will break one test in an internal downstream project so we don't need to do any magic backwards compatibility mapping like we did in Pyface or TraitsUI.