Remove is_qt4 checks#852
Closed
aaronayres35 wants to merge 2 commits into
Closed
Conversation
Contributor
|
We can't remove code that handles qt4 from the codebase yet. Removing it from the testsuite is still acceptable but not from the package itself. We'll have to close/shelve this (and PRs like these until later). |
Contributor
Author
I sort of figured this was too much too soon, but opened the PR anyway as it was fresh on my mind. We can shelve these until they are ready |
Contributor
|
This is fixed by #1043 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targeting
stop-testing-pyqt4. This PR sits on top of #851 and removesis_qt4checks from the code base.