Skip to content

Update travis#348

Merged
rahulporuri merged 4 commits into
masterfrom
dev/update-edm-travis
Jun 3, 2019
Merged

Update travis#348
rahulporuri merged 4 commits into
masterfrom
dev/update-edm-travis

Conversation

@rahulporuri
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri commented Jun 3, 2019

  • update edm version from 1.5.2 to 1.11.0
  • update the test matrix to run tests for all supported toolkits for a runtime in the same job.
  • disallow failure on wx toolkit on python 2.7

Poruri Sai Rahul added 3 commits June 3, 2019 12:39
DEV : Update edm version to 1.11.0 fro 1.5.2
3065913 
	modified:   .travis.yml
REF : Spawn fewer jobs
8ef1acb 
The test matrix has been condensed.

We now have two jobs per runtime, one where we test all toolkits
with pillow and the other where we test pillow version < 3.0
with the null toolkit

	modified:   .travis.yml
CLN : Disallow failure on wx toolkit on python 2.7
f5e43c3 
	modified:   .travis.yml
@rahulporuri
Copy link
Copy Markdown
Contributor Author

rahulporuri commented Jun 3, 2019

hmm. looks like we still have failures on wx + python 2.7

Details 
======================================================================
FAIL: test_horizontal_mouse_wheel (enable.tests.wx.mouse_wheel_test_case.MouseWheelTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/.edm/envs/enable-test-2.7-wx-pillow/lib/python2.7/site-packages/enable-4.7.1.dev73-py2.7-linux-x86_64.egg/enable/tests/wx/mouse_wheel_test_case.py", line 85, in test_horizontal_mouse_wheel
    self.assertEqual(self.tool.event.mouse_wheel_delta, (200, 0))
AssertionError: <undefined> != (200, 0)
======================================================================
FAIL: test_vertical_mouse_wheel (enable.tests.wx.mouse_wheel_test_case.MouseWheelTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/.edm/envs/enable-test-2.7-wx-pillow/lib/python2.7/site-packages/enable-4.7.1.dev73-py2.7-linux-x86_64.egg/enable/tests/wx/mouse_wheel_test_case.py", line 66, in test_vertical_mouse_wheel
    self.assertEqual(self.tool.event.mouse_wheel_delta, (0, 200))
AssertionError: <undefined> != (0, 200)
======================================================================
FAIL: enable.tests.test_assistant_test_case.test_mouse_move_real_window
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/.edm/envs/enable-test-2.7-wx-pillow/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/travis/.edm/envs/enable-test-2.7-wx-pillow/lib/python2.7/site-packages/traitsui/tests/_tools.py", line 129, in wrapper
    return test_func(*args, **kwargs)
  File "/home/travis/.edm/envs/enable-test-2.7-wx-pillow/lib/python2.7/site-packages/enable-4.7.1.dev73-py2.7-linux-x86_64.egg/enable/tests/test_assistant_test_case.py", line 32, in test_mouse_move_real_window
    window = Window(None, component=component)
  File "/home/travis/.edm/envs/enable-test-2.7-wx-pillow/lib/python2.7/site-packages/enable-4.7.1.dev73-py2.7-linux-x86_64.egg/enable/wx/base_window.py", line 172, in __init__
    self.control = control = self._create_control(parent, wid, pos, size)
  File "/home/travis/.edm/envs/enable-test-2.7-wx-pillow/lib/python2.7/site-packages/enable-4.7.1.dev73-py2.7-linux-x86_64.egg/enable/wx/base_window.py", line 221, in _create_control
    wx.WANTS_CHARS)
  File "/home/travis/.edm/envs/enable-test-2.7-wx-pillow/lib/python2.7/site-packages/wx/_core.py", line 9145, in __init__
    _core_.Window_swiginit(self,_core_.new_Window(*args, **kwargs))
PyAssertionError: C++ assertion "Assert failure" failed at /home/vagrant/workspace/Buildsystem/test/pisi/tmp/wxPython-3.0.2.0-7/work/wxPython-src-3.0.2.0/src/gtk/window.cpp(2434) in Create(): wxWindowGTK creation failed
======================================================================
FAIL: enable.tests.test_assistant_test_case.test_mouse_move_real_window_mocked_position
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/.edm/envs/enable-test-2.7-wx-pillow/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/travis/.edm/envs/enable-test-2.7-wx-pillow/lib/python2.7/site-packages/traitsui/tests/_tools.py", line 129, in wrapper
    return test_func(*args, **kwargs)
  File "/home/travis/.edm/envs/enable-test-2.7-wx-pillow/lib/python2.7/site-packages/enable-4.7.1.dev73-py2.7-linux-x86_64.egg/enable/tests/test_assistant_test_case.py", line 54, in test_mouse_move_real_window_mocked_position
    window = Window(None, component=component)
  File "/home/travis/.edm/envs/enable-test-2.7-wx-pillow/lib/python2.7/site-packages/enable-4.7.1.dev73-py2.7-linux-x86_64.egg/enable/wx/base_window.py", line 172, in __init__
    self.control = control = self._create_control(parent, wid, pos, size)
  File "/home/travis/.edm/envs/enable-test-2.7-wx-pillow/lib/python2.7/site-packages/enable-4.7.1.dev73-py2.7-linux-x86_64.egg/enable/wx/base_window.py", line 221, in _create_control
    wx.WANTS_CHARS)
  File "/home/travis/.edm/envs/enable-test-2.7-wx-pillow/lib/python2.7/site-packages/wx/_core.py", line 9145, in __init__
    _core_.Window_swiginit(self,_core_.new_Window(*args, **kwargs))
PyAssertionError: C++ assertion "Assert failure" failed at /home/vagrant/workspace/Buildsystem/test/pisi/tmp/wxPython-3.0.2.0-7/work/wxPython-src-3.0.2.0/src/gtk/window.cpp(2434) in Create(): wxWindowGTK creation failed

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 3, 2019 •
edited
Loading

Codecov Report

Merging #348 into master will decrease coverage by 1.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #348      +/-   ##
==========================================
- Coverage   33.94%   32.93%   -1.02%     
==========================================
  Files         206      206              
  Lines       18290    18290              
  Branches     2414     2414              
==========================================
- Hits         6209     6024     -185     
- Misses      11688    11880     +192     
+ Partials      393      386       -7
Impacted Files Coverage Δ
enable/null/image.py 0% <0%> (-85.72%) ⬇️
kiva/fonttools/afm.py 13.95% <0%> (-31.17%) ⬇️
kiva/fonttools/font_manager.py 40.92% <0%> (-15.33%) ⬇️
enable/component_editor.py 75% <0%> (-4.17%) ⬇️
enable/colors.py 21.73% <0%> (-3.27%) ⬇️
kiva/trait_defs/kiva_font_trait.py 73.43% <0%> (-3.13%) ⬇️
enable/tools/hover_tool.py 34.32% <0%> (-2.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768e791...7d18b33. Read the comment docs.

jwiggins
jwiggins approved these changes Jun 3, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We should consider removing Python 3.5 tests as well, but not here.

@rahulporuri
Copy link
Copy Markdown
Contributor Author

rahulporuri commented Jun 3, 2019

thanks for the review @jwiggins

@rahulporuri rahulporuri merged commit fa7cdf1 into master Jun 3, 2019
@rahulporuri rahulporuri deleted the dev/update-edm-travis branch June 3, 2019 15:02
rahulporuri pushed a commit that referenced this pull request Sep 24, 2019
FIX : Use the correct env name TOOLKITS
58102cc 
PR #348 didnt broke the travis config for three jobs, which didnt
use the updated TOOLKITS env var and were instead using the old
TOOLKIT env var, which doesnt get picked up by the CI jobs.

	modified:   .travis.yml
@rahulporuri rahulporuri mentioned this pull request Sep 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwiggins jwiggins jwiggins approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rahulporuri @codecov-io @jwiggins