Use the correct env name TOOLKITSin CI#366
Merged
Merged
Conversation
PR #348 didnt broke the travis config for three jobs, which didnt use the updated TOOLKITS env var and were instead using the old TOOLKIT env var, which doesnt get picked up by the CI jobs. modified: .travis.yml
jwiggins
approved these changes
Sep 24, 2019
Contributor
Author
|
I just checked the jobs and they are definitely doing what we expect them to now - using the |
Merged
jwiggins
pushed a commit
that referenced
this pull request
Sep 30, 2019
Use the correct env name `TOOLKITS`in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #348 I broke the travis config for three jobs, which didnt use the updated
TOOLKITSenv var and were instead using the oldTOOLKITenv var, which doesnt get picked up by the CI jobs.