Nose captures logs!#367
Merged
Merged
Conversation
Member
|
Can you rebase this on to the latest master? (ie: post #366) |
jwiggins
approved these changes
Sep 24, 2019
Member
jwiggins
left a comment
jwiggins
left a comment
There was a problem hiding this comment.
Nevermind, this is good to go.
Codecov Report
@@ Coverage Diff @@
## master #367 +/- ##
==========================================
- Coverage 33.43% 32.91% -0.52%
==========================================
Files 206 206
Lines 18303 18303
Branches 2415 2415
==========================================
- Hits 6119 6024 -95
- Misses 11802 11893 +91
- Partials 382 386 +4
Continue to review full report at Codecov.
|
which is why we werent seeing the kiva font manager related logs/tracebacks on the enable test runs but we were seeing them in other package test runs! modified: ci/edmtool.py
rahulporuri
force-pushed
the
fix/nose-captures-logs
branch
from
6882fad to
e8d4f14
Compare
Contributor
Author
|
ohh damn. i only saw your first comment in the email and i rebased this. i'll merge once CI is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nose was capturing logs when running the test suite, which is why we werent seeing the kiva font manager related logs/tracebacks on the enable test runs but we were seeing them in other package test runs!
(I checked the following packages and they make sure that nose doesnt capture logs - traits, traitsui, pyface. chaco doesn't use nose anymore.)