TST: Switch on default warning flag for CI test command#469
Merged
Conversation
jwiggins
approved these changes
Dec 6, 2020
Comment on lines
+265
to
+266
| "edm run -e {environment} -- python -W default -m" | ||
| "coverage run -m nose.core enable -v --nologcapture", |
Member
There was a problem hiding this comment.
It might be helpful to wrap these multi-line commands in parentheses so that it's clear they belong together. Otherwise you have to be paying attention to the tiny commas that separate the commands.
Codecov Report
@@ Coverage Diff @@
## master #469 +/- ##
=======================================
Coverage 30.15% 30.15%
=======================================
Files 206 206
Lines 18139 18139
Branches 2459 2459
=======================================
Hits 5469 5469
Misses 12331 12331
Partials 339 339 Continue to review full report at Codecov.
|
jwiggins
approved these changes
Dec 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #434
This PR makes the exact same fix that was done in enthought/envisage#326 and enthought/traitsui#1059. It adds the adds the -W default flag.