Skip to content

TST: Switch on default warning flag for CI test command#1059

Merged
kitchoi merged 2 commits into
masterfrom
tst-add-warning-flag
Jul 24, 2020
Merged

TST: Switch on default warning flag for CI test command#1059
kitchoi merged 2 commits into
masterfrom
tst-add-warning-flag

Conversation

@kitchoi
Copy link
Copy Markdown
Contributor

@kitchoi kitchoi commented Jul 23, 2020

Deprecation warnings triggered during test runs are visible, but deprecation warnings triggered prior to when a unittest test case is loaded are by default hidden from the console.

With that, deprecation warnings from trait types definition do not show up from running the current test command, because the warnings occur at import time.

This PR adds the -W default flag to make these warnings visible so that we can fix them more easily.

@kitchoi kitchoi requested a review from rahulporuri July 23, 2020 13:31
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri rahulporuri requested a review from aaronayres35 July 24, 2020 08:53
@rahulporuri
Copy link
Copy Markdown
Contributor

@kitchoi kitchoi merged commit 4acba2f into master Jul 24, 2020
@kitchoi kitchoi deleted the tst-add-warning-flag branch July 24, 2020 09:08
Copy link
Copy Markdown
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants