Skip to content

Add Windows to the GitHub Actions CI test matrix#539

Merged
kitchoi merged 5 commits into
masterfrom
github-actions-win
Jan 12, 2021
Merged

Add Windows to the GitHub Actions CI test matrix#539
kitchoi merged 5 commits into
masterfrom
github-actions-win

Conversation

@kitchoi
Copy link
Copy Markdown
Contributor

@kitchoi kitchoi commented Jan 12, 2021

This is another incremental step towards moving what we currently have on Travis/Appveyor to GitHub Actions.

This PR adds Windows to the existing CI matrix.

One test being modified fails when we switch to the Windows worker from GitHub Actions. The test is trying to make sure that the ComponentEditor.width and ComponentEditor.height are taken into account for setting the component view size, but the upper bound in the test is only an approximation, because the window can be a bit larger due to borders and native screen size.

The test failure looks like this:

======================================================================
FAIL: test_initial_component_with_item_size (enable.tests.test_component_editor.TestComponentEditor)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\enable\enable\.edm\envs\enable-test-3.6-wx\lib\site-packages\enable\tests\test_component_editor.py", line 65, in test_initial_component_with_item_size
    self.assertLess(size[1], ITEM_HEIGHT+30)
AssertionError: 241 not less than 230

The 30 is a tolerance, instead of increasing the tolerance, I removed the assertion altogether.

Comment thread .github/workflows/test-with-edm.yml Outdated
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a question/doubt.

@kitchoi kitchoi merged commit d4c961c into master Jan 12, 2021
@kitchoi kitchoi deleted the github-actions-win branch January 12, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants