Add Windows to the GitHub Actions CI test matrix#539
Merged
Conversation
rahulporuri
reviewed
Jan 12, 2021
rahulporuri
approved these changes
Jan 12, 2021
Contributor
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM apart from a question/doubt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another incremental step towards moving what we currently have on Travis/Appveyor to GitHub Actions.
This PR adds Windows to the existing CI matrix.
One test being modified fails when we switch to the Windows worker from GitHub Actions. The test is trying to make sure that the
ComponentEditor.widthandComponentEditor.heightare taken into account for setting the component view size, but the upper bound in the test is only an approximation, because the window can be a bit larger due to borders and native screen size.The test failure looks like this:
The
30is a tolerance, instead of increasing the tolerance, I removed the assertion altogether.