Skip to content

Add Windows to the GitHub Actions CI test matrix #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kitchoi merged 5 commits into from
Jan 12, 2021
Merged

Add Windows to the GitHub Actions CI test matrix #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6ef971b
Add Windows, expect a test to fail due to screen size
kitchoi Jan 12, 2021
1643ad5
Remove unreliable assertion, it fails when the host machine is different
kitchoi Jan 12, 2021
539d54b
Flip back to pull_request trigger
kitchoi Jan 12, 2021
0c73161
Improve comment
kitchoi Jan 12, 2021
6c3b51e
Clarify comment
kitchoi Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/test-with-edm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,15 @@ jobs:
test-with-edm:
strategy:
matrix:
os: [macos-latest]
os: [macos-latest, windows-latest]
toolkit: ['pyqt', 'pyqt5', 'pyside2', 'wx']
runs-on: ${{ matrix.os }}
env:
# Set root directory, mainly for Windows, so that the EDM Python
# environment lives in the same drive as the cloned source. Otherwise
# 'pip install' raises an error while trying to compute
# relative path between the site-packages and the source directory.
EDM_ROOT_DIRECTORY: ${{ github.workspace }}/.edm
steps:
- uses: actions/checkout@v2
- name: Cache EDM packages
Expand Down
4 changes: 0 additions & 4 deletions enable/tests/test_component_editor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,5 @@ def test_initial_component_with_item_size(self):

size = get_dialog_size(ui.control)

# leave a few pixel of margin for wx
self.assertGreater(size[0], ITEM_WIDTH-1)
self.assertLess(size[0], ITEM_WIDTH+30)

self.assertGreater(size[1], ITEM_HEIGHT-1)
self.assertLess(size[1], ITEM_HEIGHT+30)