Skip to content

Set encoding when saving image from SVG backend.#735

Merged
rahulporuri merged 1 commit into
masterfrom
fix/svg-output-win
Mar 22, 2021
Merged

Set encoding when saving image from SVG backend.#735
rahulporuri merged 1 commit into
masterfrom
fix/svg-output-win

Conversation

@rahulporuri
Copy link
Copy Markdown
Contributor

fixes #734

This PR fixes an issue with the SVG backend where saving to an image when running the enable benchmark was failing with an encoding issue. This was fixed by simply setting the encoding when saving the image.

the failure was observed when running enable.gcbench on windows

	modified:   kiva/svg.py
@rahulporuri rahulporuri requested a review from jwiggins March 22, 2021 11:04
Copy link
Copy Markdown
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rahulporuri rahulporuri merged commit 84f75d3 into master Mar 22, 2021
@rahulporuri rahulporuri deleted the fix/svg-output-win branch March 22, 2021 11:21
jwiggins pushed a commit that referenced this pull request Mar 24, 2021
the failure was observed when running enable.gcbench on windows

	modified:   kiva/svg.py
jwiggins pushed a commit that referenced this pull request Mar 25, 2021
the failure was observed when running enable.gcbench on windows

	modified:   kiva/svg.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SVG backend fails with encoding issue when running benchmark

2 participants