More cherry picks for 5.1.0#756
Merged
Merged
Conversation
the failure was observed when running enable.gcbench on windows modified: kiva/svg.py
Contributor
Member
Author
|
I wasn't sure if the documentation PRs mattered or not... I suppose it's better practice to do the release docs build from the release tag. The two code change PRs you reference are probably safe as well. |
Closed
rahulporuri
approved these changes
Mar 25, 2021
Contributor
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM. It looks like you'll need to update the changelog again 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are cherry-picks of recent PRs which I think should be included in 5.1.0. Please advise if you disagree or have other suggestions. PRs: #735, #745, #749, #755, #751