Update constrained layout documentation#746
Conversation
notmatthancock
left a comment
notmatthancock
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the additional explanations. Just one question.
| :data:`spacer`: Creates space between two adjacent components. | ||
|
|
||
| .. function:: horizontal(*components[, spacing=10]) | ||
| .. function:: hbox(*components[, spacing=10, margins=...]) |
There was a problem hiding this comment.
Why ... instead of 0?
There was a problem hiding this comment.
Because margins has several possible values which are enumerated below this line
There was a problem hiding this comment.
Yes, I thought this line was meant to indicate the default value that the parameter takes on, not to indicate the range of types that it accepts, which is why I thought it might read 0 instead.
It doesn't matter too much; I was just curious since I hadn't seen ellipsis used like this.
aaronayres35
left a comment
aaronayres35
left a comment
There was a problem hiding this comment.
Changes LGTM
I notice that none of the links to classes, traits, etc. in this file actually successfully link to api docs which would be a nice improvement.
Also, doesn't need to go in to this PR by any means, but a full fledged example and/or some screenshots showing different layouts and code to achieve them might make the documentation much easier/quicker to understand
|
Thanks for the reviews |
3 participants
Resolves #706