Don't test drawing on Qt4#745
Conversation
rahulporuri
left a comment
There was a problem hiding this comment.
Code changes LGTM but I don't know if there are any documentation changes that are necessary. I'm not entirely sure what all backends will continue to support Qt4 and Qt5 once we start depending on pillow >= 7.2.0. I think the agg and celiagg backends will continue supporting both Qt4 and Qt5. Is that correct?
|
Yes, the AGG backends will continue to support Qt4 and Qt5. We can also just "vendor" the |
I don't think we need that at the moment. We can announce with the 5.1.0 release that Qt4 is only supported by the agg backends if the edm eggs are used (because itll depend on pillow >= 7.2.0) and if someone complains, we can consider vendoring that code. Otherwise, i think it's an unnecessary maintenance overhead. |
|
Thanks for the review |
Our Pillow requirement has been upgraded to version 7.2.0 in EDM. This version removed support for Qt4. To get CI working again, we should skip tests of QPainter drawing on Qt4.