Minor formatting cleanup in kiva compiled path#783
Closed
rahulporuri wants to merge 2 commits into
Closed
Conversation
aaronayres35
suggested changes
Apr 19, 2021
Contributor
aaronayres35
left a comment
aaronayres35
left a comment
There was a problem hiding this comment.
It looks like every changed line is now under indented by one level.
In fact the indentation looks correct on master for me, I am not sure what is going on here
modified: kiva/agg/src/kiva_compiled_path.h
Contributor
aaronayres35
left a comment
aaronayres35
left a comment
There was a problem hiding this comment.
These now look correctly aligned on github, but when i checkout the branch and view the file on VS Code things are under indented / off. On master things look correctly aligned for me locally in VSCode...
Contributor
Author
|
im just going to close this. this might just be something wonky on github or maybe its spaces vs tabs or i dont know wth. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at the kiva compiled path module while reviewing #782 and I noticed awkward indentation in the module. This PR fixes that.