Update custom marker as scale_ctm expects floats

[aaronayres35]

Needed to close enthought/chaco#232

Down in agg the method that gets called wants double inputs. If an int gets passed it things break. Changing the inputs to floats seems to resolve the problem.

[rahulporuri]

I don't see any unittests for the CustomMarker code so let's take advantage of this opportunity to add some.

[rahulporuri]

LGTM. Ref

enable/kiva/agg/src/kiva_compiled_path.h

Line 124 in a1a6059

void scale_ctm(double sx, double sy);

.

I'd still like it if we could add a few tests.

[aaronayres35]

I'd still like it if we could add a few tests.

👍 I've added 2 regression tests

[aaronayres35]

CI is failing with

======================================================================
ERROR: test_get_compiled_path (enable.tests.test_markers.TestCustomMarker)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/runner/work/enable/enable/.edm/envs/enable-test-3.6-wx/lib/python3.6/site-packages/enable/tests/test_markers.py", line 50, in test_get_compiled_path
    marker.get_compiled_path(np.int64(0))
  File "/Users/runner/work/enable/enable/.edm/envs/enable-test-3.6-wx/lib/python3.6/site-packages/enable/markers.py", line 424, in get_compiled_path
    newpath.scale_ctm(float(size), float(size))
AttributeError: 'kiva.quartz.ABCGI.CGMutablePath' object has no attribute 'scale_ctm'

----------------------------------------------------------------------

perhaps this test just needs to be skipped on some combination of quartz / macos / wx? I am marking this as a WIP until I get a chance to look into this more

[rahulporuri]

Still LGTM

[rahulporuri]

not an actionable comment - i was wondering if the enable testsuite should always import from enable.api instead of importing from the specific modules. Note that this is a more general question for ETS/package development.

[aaronayres35]

Yeah I notice some of the test files do but others don't. I think it probably makes sense to use api everywhere in tests

[jwiggins]

perhaps this test just needs to be skipped on some combination of quartz / macos / wx? I am marking this as a WIP until I get a chance to look into this more

This behavior of CompiledPath is only possible with kiva.agg due to a design defect (see #716)